Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Clang 15 warnings #93

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HennerM
Copy link

@HennerM HennerM commented Jan 7, 2024

Related to triton-inference-server/server#6768 I got errors when compiling with Clang 15

  • unused private field request_count_. This doesn't seem to be used, the number of requests is always assumed to be responses->size() I don't know if this is intentionally or a bug? @GuanLuo. Since this isn't used, I added a constructor that doesn't require it and kept the other one for backward compatibility. This means one more constructor to maintain at the benefit of one less constructor parameter to pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant